fix: invalid scripts warning fixed for undefined scripts #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
May 22, 2024
lib/normalize.js
Outdated
| @@ -264,7 +264,8 @@ const normalize = async (pkg, { strict, steps, root, changes, allowLegacyCase }) | |||
| } | |||
| } | |||
| } else { | |||
| changes?.push(`Removed invalid "scripts"`) | |||
| // it only makes sense to fix if package.json has scripts field | |||
| data.scripts && changes?.push(`Removed invalid "scripts"`) | |||
There was a problem hiding this comment.
Let's make this an else if statement
There was a problem hiding this comment.
Sure, I see some other scenarios as well that I'll cover in next changes
There was a problem hiding this comment.
These changes were not respecting false values like null, 0 or ''. Instead modified top if condition to check if package has scripts then only do the updates.
milaninfy
force-pushed
the
mm/invalid-script-warning-fix
branch
from
d7ae3c6
to
dcf39ad
Compare
antongolub
reviewed
May 23, 2024
wraithgar
reviewed
May 23, 2024
wraithgar
approved these changes
May 23, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- ## [5.1.1](v5.1.0...v5.1.1) (2024-05-28) ### Bug Fixes * [`54756d2`](54756d2) [#105](#105) apply `securePath` to package bin (#105) (@antongolub) * [`46c563b`](46c563b) add `normalizePackageMan` helper (#100) (@antongolub) * [`a974274`](a974274) prevent `directory.man` referencing outside the package root (#104) (@antongolub) * [`191b521`](191b521) [#102](#102) invalid scripts warning fixed for undefined scripts (#102) (@milaninfy) ### Chores * [`45a2937`](45a2937) [#98](#98) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) * [`90863c1`](90863c1) [#98](#98) postinstall for dependabot template-oss PR (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes npm/cli#7127