-
Notifications
You must be signed in to change notification settings - Fork 3k
Conversation
FYI: We update the authors file automatically as part of our release process, so we don't look for that in pull requests. As for this pull request, I'm happy to take this, but I think I'm going to remove the env logging as I fear that would make our already large logs much too big. If you'd like to pick out some key env vars, I'd probably be up for that though. |
e77b7c8
to
ff6319c
Compare
I had this doubt too, but first I have no idea whether |
This is to reduce the amount of frustraction while troubleshooting various custom lifecycle script environment. Cons: user's privacy, if any
To make debugging of lifecycle scripts easier PR-URL: #9227
Thanks, commented on one little nit. Can we have this in 2.x as well? |
The team decided that it wasn't worth the time to backport this to |
Can we discuss the 2.x issue again? This was a missing feature from the start. I got another issue with running lifecycle script in some kind of restricted environment (sass/node-sass#1138) and the log says only "17721 info node-sass@3.3.2 Failed to exec install script". npm 2.x will be around for some time and it is really difficult to troubleshoot anything related to custom lifecycle scripts this way.... |
This is to reduce the amount of frustraction while troubleshooting various custom lifecycle script environment.
Cons: user's privacy, if any