Revert "Exclude common core dump file names by default" #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core".
isaacs
added a commit
that referenced
this pull request
Oct 9, 2019
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core". PR-URL: #38 Credit: @isaacs Close: #38 Reviewed-by: @isaacs
isaacs
added a commit
that referenced
this pull request
Oct 9, 2019
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core". PR-URL: #38 Credit: @isaacs Close: #38 Reviewed-by: @isaacs
isaacs
added a commit
that referenced
this pull request
Oct 9, 2019
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core". PR-URL: #38 Credit: @isaacs Close: #38 Reviewed-by: @isaacs
isaacs
added a commit
that referenced
this pull request
Oct 9, 2019
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core". PR-URL: #38 Credit: @isaacs Close: #38 Reviewed-by: @isaacs
isaacs
added a commit
that referenced
this pull request
Oct 9, 2019
This reverts commits 1cd776c and 800f03d. While it's a great idea to not publish core dumps to the npm registry, this approach is too blunt, and has broken a lot of packages in the process. Attempts to restrict the core dump file handling to avoid excluding folders ends up including anything in any folder named core, which is _also_ a problem. An optimal solution would look at the actual files along the walk, and filter them out if they're actually core dumps, using a more reliable indicator than the filename "core". PR-URL: #38 Credit: @isaacs Close: #38 Reviewed-by: @isaacs
|
This is included in #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits 1cd776c and
800f03d.
While it's a great idea to not publish core dumps to the npm registry,
this approach is too blunt, and has broken a lot of packages in the
process.
Attempts to restrict the core dump file handling to avoid excluding
folders ends up including anything in any folder named core, which is
also a problem.
An optimal solution would look at the actual files along the walk, and
filter them out if they're actually core dumps, using a more reliable
indicator than the filename "core".
@addaleax, I'd love to discuss how best to address the original problem that led to #8 being created. I think we can fix it in a way that doesn't require so many workarounds.