"core" folder missing on NPM registry

[TheOptimisticFactory]

Greetings,

The Pull-Request n°8 got one of our Lerna projects broken due to a folder named "/lib/core" being missing on the NPM registry.

After some debugging, I have tracked the origin of the missing folder to the aforementioned PR.
The missing folder has nothing to do with a Linux core dump but instead contains the core components of the private tool we are hosting on NPM.

For the time being, we worked around the issue by adding !/lib/core in the local folder of the tool so that it overrides the default blacklist.

An option to disable that behavior would be nice as mentioned in the PR itself: #8 (comment)

[RomainMuller]

Also affected as this was factored in npm@6.8.0. This was an extremely surprising change and I would expect it to breaks tuff somewhat pervasively.

[shadowspawn]

Some comments on the core changes:

1. the README here and the corresponding info in npm-developers have not been updated to mention core.

2. I expect the intent of the change is to exclude files named core but it also matches folders named core. I wonder whether can achieve that with something like "core", "!core/" early in default exclude list. (Probably too messy even if possible.)

[shadowspawn]

The core change can also affect installs such as from github, and not just npm pack and npm publish: https://npm.community/t/npm-pack-leaving-out-files-6-8-0-only/5382/7

[AitorGuerrero]

I have a "common" utils repo required through git in almost all my microservices, (basically, types and some classes to ease the communication between them). Suddenly, all my classes and types from the "core" service disappeared in my services.

I think this behaviour should be undone as it breaks functional code, and is included in a minor update.

[isaacs]

I agree this is probably not worthwhile to include core in the list of default exclusions.

I'm talking to the team and suggesting that we back that name out of the list in the next release.

In the meantime, anyone affected by this can either add core to the package.json files list, or create a .npmignore file containing !core, as a workaround.

[LvChengbin]

It's really a surprise.