Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exit-code): account for null default #46

Merged
merged 1 commit into from
May 26, 2021
Merged

fix(exit-code): account for null default #46

merged 1 commit into from
May 26, 2021

Conversation

wraithgar
Copy link
Member

The cli passes in null here, so we have to default it with a truthiness check, not a property check.

References

Closes npm/cli#2868

@wraithgar wraithgar requested a review from a team as a code owner May 14, 2021 18:33
@isaacs
Copy link
Contributor

isaacs commented May 26, 2021

This is clearly correct.

@wraithgar wraithgar merged commit dff5941 into latest May 26, 2021
@wraithgar wraithgar deleted the gar/audit-level-default branch May 26, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm audit does not exit with exit code 1 if a vulnerability is found
3 participants
@wraithgar @isaacs @nlf