Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support packument without versions #85

Merged

Conversation

vigan-abd
Copy link
Contributor

This PR fixes issue 84 that is caused when npm tries to audit packages that are installed as github dependencies. These packages don't have any versions on loaded packument and this is causing breaking error because Object.keys doesn't work on null/undefined and also later codebase tries to access versions property of undefined versions field.

References

Related to #84
Fixes #84
Closes #84

@vigan-abd vigan-abd requested a review from a team as a code owner April 12, 2023 09:47
@vigan-abd vigan-abd requested review from fritzy and removed request for a team April 12, 2023 09:47
@wraithgar wraithgar changed the title Bugfix/support packument without versions fix: support packument without versions Apr 12, 2023
@wraithgar wraithgar merged commit d89da3f into npm:main Apr 12, 2023
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
@rainabba
Copy link

@vigan-abd Thank you! My team will be relieved to hear.

@rainabba
Copy link

@wraithgar Any idea when this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot convert undefined or null to object in case of installing a dependency from github
3 participants