fix!: Address breaking engine change in dependency #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node 14.17.0 no longer works due to isaacs/node-glob@435d1f7 BREAKING CHANGE: `@npmcli/map-workspaces` is now compatible with the following semver range for node: `^16.13.0 || >=18.0.0`
hashtagchris
force-pushed
the
hashtagchris-glob-reaction
branch
from
bf41cec to
0b203b8
Compare
hashtagchris
changed the title
|
closing this out as we're doing engine updates now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Node 14 from
engines. node 14.17.x no longer works due to isaacs/node-glob@435d1f7. If this change is approved, I intend to apply the same change to othernpm-clirepos that useglob@10.Alternative solutions:
^14.18.0. In the past this has been considered a breaking change, and requires increase of the major version. Howeverenginesis already inaccurate if you install the latest version ofglob@10. 🤔glob@10.3.12to keep node 14.17.x working. However we'll lose the fix for Inconsistency when run in root drive path/, prefixes match with/isaacs/node-glob#584Discovered via the CI for #162