fix: turn off promise/always-return #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do we get to a point where we can turn this back on? |
|
Closing this. While it's a lot of manual work to fix, this rule is good and we should apply it everywhere by default. We should be working to fix it as we go. It can be turned off per file, project, line, etc if it blocks linting but those are easier to spot and fix iteratively in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this PR in the CLI to get a feel for how the new rules from #34 and this rule creates a lot of errors.
I can see how this helps avoid errors but we use Promises a lot for control flow that doesn't return a value. I suggest we turn this off.
Ref: https://github.com/xjamundx/eslint-plugin-promise/blob/development/docs/rules/always-return.md