[Accessibility fixes] #1268
Merged
[Accessibility fixes] #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpg619
requested review from
leobalter,
monishcm and
wraithgar
as code owners
leobalter
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request includes changes to enhance the user interface and improve code readability in the
src/components/page-footer.jsandsrc/mdx/code.jsfiles. The most important changes involve modifying the display of the latest commit information and enhancing the styling of code comments.User Interface Enhancements:
src/components/page-footer.js: Removed thecolor: 'fg.muted'style from theTextcomponent that displays the latest commit information.Code Readability Improvements:
src/mdx/code.js: Enhanced theMonoTextcomponent to apply a specific color (#747459) to comments within code blocks. This change ensures that comments are visually distinct from other code elements.WHY
This PR includes changes regarding accessibility bug fixes.
Change 1: The text
commentcolour is changed for better accessibility.Change 2: From the text
Last edited bythe muted colour is removed for better colour contrast ratio.