Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with sub folder local references #86

Merged
merged 6 commits into from
Feb 7, 2019
Merged

Fix issue with sub folder local references #86

merged 6 commits into from
Feb 7, 2019

Conversation

jtwebman
Copy link
Contributor

@jtwebman jtwebman commented Oct 25, 2018

@jtwebman
Copy link
Contributor Author

@zkat or any one else that has write access to this repo can you re-run the failed test? Looks like Travis-CI had issues nothing to do with the code.

@zkat zkat changed the base branch from latest to release-next November 13, 2018 15:23
@zkat zkat added semver:patch semver patch level for changes needs-discussion labels Nov 13, 2018
@zkat
Copy link
Contributor

zkat commented Nov 13, 2018

I'm gonna want to review this with @iarna before merging.

@aukevanleeuwen
Copy link

I'm not really in favor of +1 like comments, but in this case: I'm really really looking forward to this fix since it seems to match my case exactly.

--
Also wanted to link npm/npm#13528 because that's where my quest started out some time ago. I know the repo is archived, but maybe that issue still gets a reference automatically.

@zoellner
Copy link

To anyone who ends up here from npm/npm#13528 and if you've run across this problem just recently: - this error recently showed up a lot because of a pulled package with a vulnerability. See dominictarr/event-stream#116 for details.

@stevebaxter
Copy link

Is there a workaround for this? This has completely screwed our project right now.

@jtwebman
Copy link
Contributor Author

jtwebman commented Dec 6, 2018

@iarna Could we get a review on this so @zkat can merge this.

@sahellebusch
Copy link

sahellebusch commented Dec 6, 2018

I'm going to echo others here since this isn't budging. This is a breaking change that is problematic to many developers. Yes, a major version, but just as JS is always backwards compatible, I would imagine the package manager would be as well. I know there are arguments for how this should be done, but for the time being this should be merged to fix the immediate needs of those who are facing the same challenges and cannot upgrade to the latest npm version.

@baptistemarchand
Copy link

@zkat @iarna are there any issues blocking this from being merged?

It looks like it would solve issues for many users.

Thanks!

@Jmacek
Copy link

Jmacek commented Jan 14, 2019

I would like to vote for this being merged soon please, this has been an issue for my team as well.

Thanks

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve this -- tests look ok, and the code is from #40, which has been pending for a while now. Cheers!

@zkat zkat force-pushed the release-next branch 5 times, most recently from db63b89 to b09bc8c Compare January 23, 2019 18:36
@baptistemarchand
Copy link

Hello,
Will this change be included in the next release? (on February 6th)
Thanks!

@jbinard
Copy link

jbinard commented Jan 29, 2019

Please add this fix in the next release, this is a real issue for my team.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.