docs(package.json): add brief section on exports, link to Node.js docs #7783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good approach: a boilerplate intro, and a link to the actual docs so that we don't run the risk of having to keep up to date w/ changes in more specific parts of the spec. |
|
I'm going to close #7323 in favor of this approach, which is what we were trying to guide that other PR towards. |
wraithgar
approved these changes
Sep 17, 2024
wraithgar
changed the title
Either don't make comments like this or communicate what you want better in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package.json docs make no reference to the
exportsproperty, which seems like a huge omissionThis PR copies a little text from the node.js docs and links to them - not sure if it's a good solution, but it's a start