-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove ", instead of updating the package lock" #7778
Conversation
- Removed ", instead of updating the package lock" from the docs because, AFAIK, that never occurs anyway. The last bullet point states this, too.
This is referring to the fact that |
@wraithgar Clarifying question: Are you saying the phrase should remain in the docs? |
Yes I think it should. |
I see. I'm not following how would a reader could know that phrase is referring to |
@DanKaplanSES a reader would know that phrase is referring to
And lists the differences between the two commands. |
Okay, I understand the thought process, but:
can also be misinterpreted as:
One way to prevent that misinterpretation is to remove the phrase entirely, but there are other ways, such as:
I'm not tied to my edit, but IMO, it should be edited in some way because it can be misinterpreted, and there are easy ways to prevent the possibility. |
Sorry I posted a message then deleted it. I think this is fine as it is theres also a heading for the list which offers further context for the sentence.
|
Hi @reggi I'm not sure I fully understand your point of view yet. Would it be misrepresenting your position if I reworded your statement like this: "This is fine because it can be interpreted correctly"? |
@DanKaplanSES I think this is fine because it can be interpreted correctly. This is a page for
If I were to have a document about
I don't think it's super ambiguous what "red" is referring to. I think this is grammatically and colloquially ok to leave it as it is. |
Remove ", instead of updating the package lock" from the docs because, AFAIK, that never occurs anyway. The last bullet point states this, too.
References