Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readable-stream dependency #67

Closed
wants to merge 1 commit into from
Closed

Conversation

pravi
Copy link

@pravi pravi commented Sep 12, 2018

as require("stream") can be used and readable-stream is no longer used.

as require("stream") can be used and readable-stream is no longer used.
@pravi pravi requested a review from a team as a code owner September 12, 2018 17:29
@kenany
Copy link
Contributor

kenany commented Sep 12, 2018

Previously: npm/npm#17528

@jmannanc
Copy link
Contributor

It's a little bit more complex then that, see #59 for more details

@pravi
Copy link
Author

pravi commented Sep 21, 2018

@sneakyfish5 thanks for the heads up. How about we try to remove readable-stream from all dependencies? I did that in debian already.

@jmannanc
Copy link
Contributor

@pravi Some of the deps might break without their specific version of readable-stream though. If you've done it already and it works though, definitely give it a shot.

@zkat
Copy link
Contributor

zkat commented Nov 13, 2018

We use readable-stream as a direct dependency to stabilize its version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants