Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @npmcli/package-json to fix prepare issue found in npm@9.7.0 #6518

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Jun 1, 2023

Converting to a draft while the commits include temporary tarball dependencies to run smoke-tests against.

Will be ready for review once: npm/package-json#36 and npm/git#137 land.

This PR contains two failing tests for the issue found in 9.7.0 and the dependency updates for @npmcli/package-json that fix it.

@lukekarrys lukekarrys requested a review from a team as a code owner June 1, 2023 22:10
@lukekarrys lukekarrys marked this pull request as draft June 5, 2023 23:32
@lukekarrys lukekarrys marked this pull request as ready for review June 6, 2023 17:43
These dependency updates fix the issue found in `9.7.0` that was the
reason for its deprecation. Specifically `npm` will now use `bin` before
`directories.bin` when looking for bin scripts. This matches the
behavior of `npm@9.6.7`.
@lukekarrys lukekarrys changed the title chore: add failing test for v9.6.7 npm manifest snapshot Update @npmcli/package-json to fix prepare issue found in npm@9.7.0 Jun 6, 2023
@lukekarrys lukekarrys merged commit 7467ff6 into latest Jun 6, 2023
@lukekarrys lukekarrys deleted the lk/npm-manifest-snapshot branch June 6, 2023 18:07
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants