Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code cleanup #6393

Merged
merged 21 commits into from
Apr 24, 2023
Merged

fix: code cleanup #6393

merged 21 commits into from
Apr 24, 2023

Commits on Apr 20, 2023

  1. fix: iterate tree only once 

    filter during the one iteration
    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b67160c View commit details
    Browse the repository at this point in the history

  2. fix: remove single use function

    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d36ea3c View commit details
    Browse the repository at this point in the history

  3. fix: streamline idealTreePrune 

    don't filter just to iterate through the list again
    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    36f52fa View commit details
    Browse the repository at this point in the history

  4. fix: optimize getChildren 

    No need to cast to an array and filter down to a second array
    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ca68725 View commit details
    Browse the repository at this point in the history

  5. fix: remove unneeded map 

    we can replace in the for loop instead
    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ade067c View commit details
    Browse the repository at this point in the history

  6. fix: create PlaceDep in for loop 

    no need to iterate just to do that step and then iterate again
    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b5c6362 View commit details
    Browse the repository at this point in the history

  7. fix: don't make new array just to iterate problemEdges

    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    612dbc5 View commit details
    Browse the repository at this point in the history

  8. fix: don't make new array just to iterate edgesOut

    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1bf346c View commit details
    Browse the repository at this point in the history

  9. fix: more efficient depsQueue

    @wraithgar
    wraithgar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    378d90e View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. fix: clean up from-path.js

    @wraithgar
    wraithgar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4c4bed6 View commit details
    Browse the repository at this point in the history

  2. fix: clean up Edge class

    @wraithgar
    wraithgar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    99a6266 View commit details
    Browse the repository at this point in the history

  3. fix: clean up ternary operators

    @wraithgar
    wraithgar committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2650ae9 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. fix: clean up lib/inventory.js

    @wraithgar
    wraithgar committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    b8c6d2e View commit details
    Browse the repository at this point in the history

  2. fix: small cleanup of lib/node.js 

    Unpack some ternaries
Remove some impossible code
Move some symbols to private attrs/methods
    @wraithgar
    wraithgar committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    9aa2903 View commit details
    Browse the repository at this point in the history

  3. fix: move to private attributes

    @wraithgar
    wraithgar committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    cd80ac7 View commit details
    Browse the repository at this point in the history

  4. fix: rename load-workspaces mixin 

    It distinguishes now between the #loadWorkspaces in lib/node.js
    @wraithgar
    wraithgar committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    01a38d1 View commit details
    Browse the repository at this point in the history

  5. fix: move to private attributes

    @wraithgar
    wraithgar committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    56dce9c View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. fix: do much less work checking root edges

    @wraithgar
    wraithgar committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    4a5d21b View commit details
    Browse the repository at this point in the history

  2. fix: move from symbols to private methods

    @wraithgar
    wraithgar committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    6641aa2 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. fix: cleaner nmContents and cache check

    @wraithgar
    wraithgar committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    b21f07b View commit details
    Browse the repository at this point in the history

  2. fix: iterate on edges instead of re-casting to array

    @wraithgar
    wraithgar committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    f4a0c05 View commit details
    Browse the repository at this point in the history