Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: init-package-json@5.0.0 #5968

Closed
wants to merge 1 commit into from
Closed

deps: init-package-json@5.0.0 #5968

wants to merge 1 commit into from

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner December 16, 2022 04:49
@lukekarrys lukekarrys force-pushed the deps/init-package-json branch 2 times, most recently from e6e892c to 8404d06 Compare December 16, 2022 05:12
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Dec 16, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.916 ±1.86 14.942 ±0.10 13.892 ±0.09 18.223 ±3.18 2.773 ±0.18 2.640 ±0.00 2.102 ±0.00 9.734 ±0.02 2.103 ±0.01 3.745 ±0.86
#5968 40.761 ±7.58 14.698 ±0.08 13.724 ±0.11 16.142 ±0.85 2.626 ±0.06 2.619 ±0.03 2.023 ±0.01 9.606 ±0.04 2.035 ±0.02 3.192 ±0.22
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 27.087 ±2.07 11.743 ±0.01 10.822 ±0.07 12.084 ±0.64 2.380 ±0.00 2.345 ±0.02 2.163 ±0.00 7.477 ±0.02 2.046 ±0.03 2.891 ±0.00
#5968 27.533 ±1.03 11.510 ±0.10 10.623 ±0.03 11.648 ±0.26 2.334 ±0.02 2.393 ±0.03 2.083 ±0.02 7.317 ±0.01 1.979 ±0.01 2.819 ±0.05

@lukekarrys lukekarrys marked this pull request as draft December 16, 2022 16:23
@lukekarrys
Copy link
Contributor Author

Converting to draft since this includes a temporary git dep on init-package-json.

@lukekarrys lukekarrys force-pushed the deps/init-package-json branch from 8404d06 to 7f81f71 Compare December 16, 2022 18:37
AKayy2020
AKayy2020 reviewed Dec 16, 2022
View reviewed changes
Copy link

@AKayy2020 AKayy2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEC

@lukekarrys lukekarrys force-pushed the deps/init-package-json branch from 7f81f71 to 797838d Compare January 1, 2023 23:22
@lukekarrys
Copy link
Contributor Author

Closing in favor of #6133

@lukekarrys lukekarrys closed this Feb 6, 2023
@lukekarrys lukekarrys deleted the deps/init-package-json branch February 6, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AKayy2020 AKayy2020 AKayy2020 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @npm-cli-bot @AKayy2020