chore: rewrite scripts/ with javascript
#5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/no-make
branch
10 times, most recently
from
82d744a to
0cb06c6
Compare
|
Since this changes the release workflow, I manually triggered it via workflow_dispatch and it succeeds: https://github.com/npm/cli/actions/runs/3325056538 |
lukekarrys
force-pushed
the
lk/no-make
branch
2 times, most recently
from
08ce810 to
33bfa10
Compare
wraithgar
approved these changes
Oct 26, 2022
lukekarrys
force-pushed
the
lk/no-make
branch
from
33bfa10 to
bac1918
Compare
Merged
Goals of this rewrite: - Better portability of scripts to anywhere we can run `node` and no reliance on `make` or other tools - More code inside `scripts/` and less inside of CI workflows to allow for easier local testing - Reuse the same scripts for similar workflows (eg `publish` and `smoke-publish`) Future goals: - Allow testing of `scripts` Some highlights of the new scripts: `scripts/create-node-pr.js` - This now operates on cloned copy of the base repo that is pushed to our fork, so we no longer need to manually sync our fork. - Uses the published registry tarball for as much of the PR as possible, falling back to including local files from source. This will enable for easier migration to eventually only using the tarball contents. `scripts/publish.js` - Replaces `make publish` - Will publish all workspaces that need to be published, before publishing the CLI. - Makes running tests an optional part of the script, since CI now runs the tests. - Can optionally only pack the tarball, for use in CI to test installing the tarball. `scripts/util.js` - Shared utilities for spawning commands including helpers for `npm` and `gh`. - Common interface for running, parsing args, logging, and debugging of scripts.
lukekarrys
force-pushed
the
lk/no-make
branch
from
bac1918 to
b705362
Compare
|
This requires a few updates to the release wiki. I will make those once this is merged. |
wraithgar
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals of this rewrite:
nodeand noreliance on
makeor other toolsscripts/and less inside of CI workflows to allowfor easier local testing
publishandsmoke-publish)Future goals:
scriptsSome highlights of the new scripts:
scripts/create-node-pr.jsour fork, so we no longer need to manually sync our fork.
falling back to including local files from source. This will enable
for easier migration to eventually only using the tarball contents.
scripts/publish.jsmake publishpublishing the CLI.
the tests.
the tarball.
scripts/util.jsnpmandgh.of scripts.