Gracefully exit login and publish commands on Ctrl+C (SIGINT) in the new webAuthn flow #5243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
This PR resolves the bug which did not allow users to exit the CLI process on hitting CTRL + C for
npm publish --auth-type=web
andnpm login auth-type=web
commands.Approach
We use
readline
to prompt the user to hit ENTER. However, the first time the user hits CTRL+C, it closes thereadline
instance (docs). The second CTRL+C then kills the CLI process. This PR adds an event listener which listens toreadline
's SIGINT event (docs) and then gracefully kills the CLI process from thecb
function.Note: The experience shown after hitting CTRL+C is kept similar to the existing experience when the user hits CTRL+C for login and publish commands without the
auth-type=web
flagThe PR also adds a test case to validate the same.
Experience
Login
login-sigint.mov
Publish
publish-sigint.mov
References
Resolves #5231