Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fund): open url for string shorthand #501

Closed

Conversation

ruyadorno
Copy link
Contributor

Overview

Trying to open url for a package that is using the string shorthand is currently broken using: npm fund <pkg>

✏️ Changes

This commit fixes the issue and adds the missing unit and integration tests covering that usecase.

🔗 References

🔍 Testing

Manual testing:
In a folder with a given package.json:

{
  "name": "foo",
  "version": "1.0.0",
  "funding": "http://example.com"
}

Running npm fund . should open the funding url in default browser:

✅ This change has unit test coverage
✅ This change has integration test coverage

🔥 Rollback

If we observe something wrong with this change in production, how should we respond?

This can be reverted at any time

Trying to open url for a package that is using the string shorthand is
currently broken using: `npm fund <pkg>`

This commit fixes the issue and adds the missing unit and integration
tests covering that usecase.

Fixes npm#498
@ruyadorno ruyadorno requested a review from a team as a code owner November 19, 2019 21:46
@mikemimik mikemimik added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes Bug thing that needs fixing labels Nov 26, 2019
@mikemimik mikemimik added this to the Release 6.14.0 milestone Nov 26, 2019
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽 🔥

@mikemimik mikemimik closed this in 1c65d26 Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants