Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runScript): obey silent loglevel #2719

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

wraithgar
Copy link
Member

If the user has specified a silent loglevel, we should pass that intention on
when we call runScript

Also a small cleanup in lib/run-script.js so that the reference to
@npmcli/run-script is named the same as other files.

@wraithgar
Copy link
Member Author

This is still a draft till the same changes can be made in pacote, libnpmpack, and libnpmversion.

@wraithgar wraithgar marked this pull request as ready for review February 18, 2021 22:19
@wraithgar wraithgar requested a review from a team as a code owner February 18, 2021 22:19
@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release labels Feb 18, 2021
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wraithgar wraithgar added the release: next These items should be addressed in the next release label Feb 19, 2021
@wraithgar
Copy link
Member Author

All of the places where we're calling runScript outside of the cli code itself have been updated and are in the v7.5.5 release branch. This should go along with them.

If the user has specified a silent loglevel, we should pass that intention on
when we call runScript

Also a small cleanup in lib/run-script.js so that the reference to
@npmcli/run-script is named the same as other files.

PR-URL: #2719
Credit: @wraithgar
Close: #2719
Reviewed-by: @nlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants