Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): refactor publish tests #2717

Merged
merged 1 commit into from
Feb 18, 2021
Merged

chore(tests): refactor publish tests #2717

merged 1 commit into from
Feb 18, 2021

Conversation

wraithgar
Copy link
Member

Less mocking, more intentional testing of things

This is an initial stab at cleaning up the tests to only mock what we need to test, and to test what we actually mean to test.

@wraithgar wraithgar requested a review from a team as a code owner February 17, 2021 22:11
@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 18, 2021
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great iteration 👍

Less mocking, more intentional testing of things

PR-URL: #2717
Credit: @wraithgar
Close: #2717
Reviewed-by: @nlf
@nlf nlf changed the base branch from latest to release/v7.5.5 February 18, 2021 21:05
@nlf nlf merged commit 80c2ac9 into release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
@wraithgar wraithgar deleted the gar/publish-tests branch November 2, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants