Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shrinkwrap in node v10.0 #2688

Merged
merged 1 commit into from
Feb 18, 2021
Merged

fix: shrinkwrap in node v10.0 #2688

merged 1 commit into from
Feb 18, 2021

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Feb 12, 2021

See #2654 (comment)

Note that this only applies to node 10.0; tests didn't catch it because errorMessage tests don't work in node 10.0 due to a broken Object.entries implementation with error instances.

@ljharb ljharb requested a review from a team as a code owner February 12, 2021 22:28
@wraithgar wraithgar added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 12, 2021
@darcyclarke darcyclarke added the semver:patch semver patch level for changes label Feb 13, 2021
@nlf nlf changed the base branch from latest to release/v7.5.5 February 18, 2021 20:37
@nlf nlf merged commit 49c9537 into npm:release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants