Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap a timer around the rimraf call in npm-ci #2573

Merged
merged 1 commit into from
Feb 1, 2021
Merged

wrap a timer around the rimraf call in npm-ci #2573

merged 1 commit into from
Feb 1, 2021

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jan 29, 2021

Fix: npm/arborist#207

References

@isaacs isaacs requested a review from a team as a code owner January 29, 2021 17:40
@isaacs isaacs mentioned this pull request Jan 29, 2021
Closed
nlf
nlf approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so because glob was traversing the whole tree we were taking forever? this totally makes sense

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 1, 2021
@isaacs isaacs changed the base branch from latest to release/7.5.1 February 1, 2021 20:00
@isaacs isaacs merged commit a8e77f2 into release/7.5.1 Feb 1, 2021
@nlf nlf deleted the isaacs/ci-rm-timer branch March 28, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm ci; 45 seconds elapses between arborist:ctor and idealTree:init
3 participants
@isaacs @nlf @darcyclarke