-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faster levenshtein #2403
faster levenshtein #2403
Conversation
Appreciate this change. We'll definitely look at this in the future but we're actually very happy w/ & prefer using deps from collaborators we've worked within different areas of the project (ex. educes the scope of maintainers we'd have to poke if any transitive dep required updating). The stats on |
Revisiting this since |
CI tests in node 10 and above |
`leven` dropped support for node10 and we still currently have to support it. Moved to https://github.com/ka-weihe/fastest-levenshtein Originally discussed in #2403, but the did-you-mean lib moved quite a bit since then and there were conflicts so I made a new PR
new PR w/o conflicts here #3640 |
`leven` dropped support for node10 and we still currently have to support it. Moved to https://github.com/ka-weihe/fastest-levenshtein Originally discussed in #2403, but the did-you-mean lib moved quite a bit since then and there were conflicts so I made a new PR
@ka-weihe sorry for the noise here, closing this again in favor of the new PR. Changing deps is usually something we do ourselves since it's more than just running |
`leven` dropped support for node10 and we still currently have to support it. Moved to https://github.com/ka-weihe/fastest-levenshtein Originally discussed in #2403, but the did-you-mean lib moved quite a bit since then and there were conflicts so I made a new PR PR-URL: #3640 Credit: @wraithgar Close: #3640 Reviewed-by: @nlf
leven is one of the slowest levenshtein packages out there and the author is trying to deceive people with shitty benchmarks where he is only comparing it slower packages. Please consider using fastest-levenshtein instead which is 10x faster and much higher quality.