**WIP** install: correctly exclude dev dependencies when using global and shrinkwrap #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inkwrap See report at https://npm.community/t/devdependencies-are-installed-if-global-flag-used-and-shrinkwrap-file-is-present/9019 Signed-off-by: Gergely Imreh <imrehg@gmail.com>
CameronDiver
approved these changes
Jul 24, 2019
|
Checked the failed build log, obviously my previous simpler testing didn't catch these cases, and have to revisit it. Sorry about that, will update this PR appropriate later. |
imrehg
changed the title
|
is there any hope the issue referenced here will be fixed soon? What's the official work around? Currently I'm trying to bypass this by the suggestion from #166
is there a better way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See report at https://npm.community/t/devdependencies-are-installed-if-global-flag-used-and-shrinkwrap-file-is-present/9019
Signed-off-by: Gergely Imreh imrehg@gmail.com