Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace npm-registry-client with npm-registry-fetch #2

Closed
wants to merge 0 commits into from
Closed

replace npm-registry-client with npm-registry-fetch #2

wants to merge 0 commits into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Jul 6, 2018 •
edited
Loading

This is the beginning of the work needed to finally obsolete npm-registry-client in favor of npm-registry-fetch. I'm starting with more trivial commands, making sure they work, and then working my way up to more involved commands.

TODO - commands that use npm-registry-client directly

  • npm view
  • npm star
  • npm stars
  • npm deprecate
  • npm ping
  • npm whoami
  • Define a figgy-pudding config for npm stuff
  • lib/utils/metrics.js
  • npm dist-tag
  • npm outdated
  • npm owner
  • npm team
  • npm access
  • npm org (PR didn't get merged. Should port anyway)
  • npm search
  • npm logout
  • npm login/adduser (should be mainly just the legacy npmE bits)
  • npm publish
  • npm unpublish
  • npm ci

TODO - need to be ported to figgy-pudding/new pacote

  • npm install
  • npm pack
  • npm ci (uggghhh)
  • npm audit
  • npm audit fix

@zkat zkat requested a review from a team as a code owner July 6, 2018 00:07
@zkat zkat mentioned this pull request Jul 9, 2018
Closed
@zkat zkat added the semver:patch semver patch level for changes label Jul 18, 2018
@zkat zkat closed this Jul 25, 2018
@zkat zkat reopened this Jul 26, 2018
@zkat zkat closed this Jul 26, 2018
@zkat zkat reopened this Jul 26, 2018
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch from 5f5be69 to bb23517 Compare July 27, 2018 01:22
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch 2 times, most recently from 0c0b7c9 to ae8d856 Compare August 16, 2018 03:02
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch 2 times, most recently from c4dcf07 to 765ff09 Compare August 16, 2018 22:36
@zkat zkat added semver:minor new backwards-compatible feature and removed semver:patch semver patch level for changes labels Aug 16, 2018
@zkat
Copy link
Contributor Author

zkat commented Aug 16, 2018

switching to semver:minor because I've started adding OTP-prompting support to some of the commands.

@zkat zkat mentioned this pull request Aug 20, 2018
Closed
@zkat zkat force-pushed the release-next branch 2 times, most recently from 05ab727 to 1bc5b8c Compare August 20, 2018 23:19
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch from e05cd01 to c4dfe41 Compare August 21, 2018 02:48
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch 6 times, most recently from 78349e8 to bc32f8b Compare August 28, 2018 23:15
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch 2 times, most recently from 4b3ce12 to aef679f Compare November 26, 2018 23:28
@octogonz octogonz mentioned this pull request Nov 27, 2018
Merged
3 tasks
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch from 9307703 to faa224c Compare November 27, 2018 19:20
@zkat zkat closed this Nov 27, 2018
@zkat zkat force-pushed the zkat/registry-fetch-replacement branch from faa224c to fcdbeae Compare November 27, 2018 19:54
@aeschright aeschright mentioned this pull request Jan 17, 2019
Closed
4 tasks
isaacs added a commit that referenced this pull request Aug 12, 2019
@isaacs
cmd-shim@2.1.0
aa22ff6 
- [`9c93ac3`](npm/cmd-shim@9c93ac3)
  [#2](npm/cmd-shim#2)
  [#3380](npm/npm#3380)
  Handle environment variables properly
  ([@basbossink](https://github.com/basbossink))

- [`2d277f8`](npm/cmd-shim@2d277f8)
  [#25](npm/cmd-shim#25)
  [#36](npm/cmd-shim#36)
  [#35](npm/cmd-shim#35) Fix 'no shebang' case
  by always providing `$basedir` in shell script
  ([@igorklopov](https://github.com/igorklopov))

- [`adaf20b`](npm/cmd-shim@adaf20b)
  [#26](npm/cmd-shim#26) Fix `$*` causing an
  error when arguments contain parentheses
  ([@satazor](https://github.com/satazor))

- [`49f0c13`](npm/cmd-shim@49f0c13)
  [#30](npm/cmd-shim#30) Fix paths for
  MSYS/MINGW bash ([@dscho](https://github.com/dscho))

- [`51a8af3`](npm/cmd-shim@51a8af3)
  [#34](npm/cmd-shim#34) Add proper support for
  PowerShell ([@ExE-Boss](https://github.com/ExE-Boss))
@Raid5594 Raid5594 mentioned this pull request Jan 8, 2020
Closed
@Link631
Copy link

Link631 commented Feb 4, 2020

What about this Issue?

I am still having this behaviour, that the noproxy setting for a domain does not work.

https://npm.community/t/npm-publish-doesnt-respect-noproxy-configuration/2464/4

@tmohammad78 tmohammad78 mentioned this pull request Mar 8, 2020
Closed
@atishay-aj atishay-aj mentioned this pull request Mar 27, 2020
Closed
@lerototi lerototi mentioned this pull request Jun 9, 2020
Closed
@RakshithHolla RakshithHolla mentioned this pull request Jul 17, 2020
Closed
This was referenced Aug 24, 2020
Closed
Closed
@kingecg kingecg mentioned this pull request Sep 16, 2020
Closed
@sindhurgowda sindhurgowda mentioned this pull request Oct 26, 2020
Closed
@ImBobot ImBobot mentioned this pull request Dec 22, 2020
Closed
@vrushabhgadkari vrushabhgadkari mentioned this pull request Jan 21, 2021
Closed
@GimmiSingh GimmiSingh mentioned this pull request May 24, 2021
Closed
1 task
@deepakraj1110 deepakraj1110 mentioned this pull request Jul 16, 2021
Closed
1 task
@RahulkumarRV RahulkumarRV mentioned this pull request Oct 30, 2021
Open
1 task
@NoobletBilal NoobletBilal mentioned this pull request Nov 8, 2021
Closed
2 tasks
@aboongm aboongm mentioned this pull request Jan 8, 2022
Closed
@astef astef mentioned this pull request Jan 9, 2022
Closed
1 task
@coolaj86 coolaj86 mentioned this pull request Aug 11, 2022
Closed
2 tasks
@notroid5 notroid5 mentioned this pull request Nov 9, 2022
Open
2 tasks
antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
@iarna @zkat
fix(shebangs): only convert CR when doing CRLF -> LF (npm#2)
43bf857 
* Finish fully promisifying

* Cleanup isHashbangFile implementation

* Only do dos2unix pass when CRs are present in hashbang file

* Rewrite dos2unix to not use streams

* Only convert shebang CR when converting CRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:minor new backwards-compatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkat @Link631