Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npx bin should be executable #1792

Closed

Conversation

ruyadorno
Copy link
Contributor

Is this file still relevant at all? it wasn't touched in a long while but I don't think I've seen anyone complaining about wrong permissions, it seems that these files are cygwin-specific.

Anyways, just opened the PR to raise attention and maybe we can revisit its existence instead. I just noticed it while navigating my local file system since all its peers (bin/npm, bin/npm-cli.js, bin/npx-cli.js) have executable permission but not this one which does not seems right.

@ruyadorno ruyadorno requested a review from a team as a code owner September 11, 2020 04:16
@darcyclarke darcyclarke added Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release beta labels Sep 11, 2020
@darcyclarke
Copy link
Contributor

Action: delete

isaacs added a commit that referenced this pull request Sep 17, 2020
@isaacs isaacs closed this Sep 17, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 15 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants