test: add lib/link.js tests #1786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ELINKGLOBAL error code for when using --global - Added tests for lib/link.js - Do not reify, only load globals when linking a pkg to a local prefix - Fixes: npm#1777
isaacs
reviewed
Sep 10, 2020
isaacs
reviewed
Sep 10, 2020
ruyadorno
added a commit
to npm/arborist
that referenced
this pull request
Sep 10, 2020
related to: npm/cli#1786 Co-authored-by: isaacs <i@izs.me>
isaacs
pushed a commit
to npm/arborist
that referenced
this pull request
Sep 10, 2020
related to: npm/cli#1786 Co-authored-by: isaacs <i@izs.me> PR-URL: #125 Credit: @ruyadorno Close: #125 Reviewed-by: @isaacs
isaacs
reviewed
Sep 10, 2020
ruyadorno
force-pushed
the
refactor-link-tests
branch
from
ef07549
to
c7eb066
Compare
Being able to npm link a package that is not currently available in the global space should still be a supported feature, this change puts that functionality back in place but also improves it by avoiding reify any package that may already be found in the global directory.
ruyadorno
force-pushed
the
refactor-link-tests
branch
from
b12d9db
to
402bd25
Compare
darcyclarke
approved these changes
Sep 15, 2020
ruyadorno
added a commit
that referenced
this pull request
Sep 16, 2020
PR-URL: #1786 Credit: @ruyadorno Close: #1786 Reviewed-by: @darcyclarke
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ELINKGLOBALerror code for when using--globallib/link.jsDo not reify, only load globals when linking a pkg to a local prefixnpm link <pkg>behavior to symlink to available package in global dir if possible, if not reify missing pkg into global dir then reify-symlink it to local dir@npmcli/arborist@0.0.23NOTE: Tests are not mocking Arborist since I think this is a cmd that might help us out surfacing underlying issues, similar to
npm ls