fix: scope config #1758
Closed
fix: scope config #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flatOptions.scope` option should not default to `projectScope` since that's causing projects that have a defined `projectScope` corresponding to configured scoped registries to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url. fix npm#1654
ruyadorno
added
Release 7.x
isaacs
pushed a commit
that referenced
this pull request
Sep 4, 2020
The `flatOptions.scope` option should not default to `projectScope` since that's causing projects that have a defined `projectScope` corresponding to configured scoped registries to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url. fix #1654 PR-URL: #1758 Credit: @ruyadorno Close: #1758 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flatOptions.scopeoption should not default toprojectScopesince that's causing projects that have a definedprojectScopecorresponding to a configured scoped registry to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url (as ifnpm install --scope="@myscope").This PR fixes it by reinstating a regular
flatOptions.scopeconfig.fix #1654