Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isaacs/new config #1688

Closed
wants to merge 8 commits into from
Closed

Isaacs/new config #1688

wants to merge 8 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Aug 18, 2020

Refactor config to @npmcli/config module.

Use APPLOCALDATA insteadof APPDATA for cache.

Fix "marker not found" race condition config loading issue in npm v7 beta.

Get rid of the lib/config/ folder, moving the remaining items into lib/utils/ where they belong.

@isaacs isaacs requested a review from a team as a code owner August 18, 2020 16:58
@npm-deploy-user
Copy link

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 50.3s🛑 39.5s 3.6s✅ 34.5s 34.4s✅ 28.1s 28.4s✅🐌 33.5s 58.6s🛑
repeat install 9.6s 12.5s🛑 8.6s 4.1s✅ 8.3s 5.2s✅ 7.7s 1.5s✅ 9.1s 22.8s🛑
with warm cache 32.3s 31.3s✅ 33.8s 4.1s✅ 31.3s 20.3s✅ 23.4s 16s✅ 29.1s 40s🛑
with node_modules 9.2s 12.3s🛑 8.6s 3.9s✅ 9s 5.4s✅ 7.8s 1.9s✅ 9.4s 23.7s🛑
with lockfile 32.6s 36.5s🛑 31s 3.5s✅ 29s 22.9s✅ 21.7s 17.2s✅ 27.4s 44.1s🛑
with warm cache and node_modules 9.3s 12.6s🛑 7.9s 4.1s✅ 8.4s 5.7s✅ 7.6s 1.8s✅ 9.2s 24.2s🛑
with warm cache and lockfile 24.7s 17.9s✅ 26.3s 4.1s✅ 24.3s 10s✅ 17.8s 5.8s✅ 21.3s 27.6s🛑
with node_modules and lockfile 10.1s 12.2s🛑 9.8s 3.6s✅ 8.6s 5.6s✅ 7.8s 1.7s✅ 9.7s 23.1s🛑

ruyadorno
ruyadorno reviewed Aug 20, 2020
View reviewed changes
lib/adduser.js
@@ -53,7 +49,7 @@ const updateConfig = async ({ newCreds, registry, scope }) => {
}

npm.config.setCredentialsByURI(registry, newCreds)
await saveConfig()
await npm.config.save('user')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

ruyadorno
ruyadorno approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ruyadorno pushed a commit that referenced this pull request Aug 20, 2020
@isaacs @ruyadorno
move flat-options.js from lib/config/ to lib/utils/
ea80f35 
PR-URL: #1688
Credit: @isaacs
Close: #1688
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno closed this Aug 20, 2020
This was referenced Aug 20, 2020
Closed
Closed
@isaacs isaacs deleted the isaacs/new-config branch October 2, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacs @npm-deploy-user @ruyadorno