Isaacs/unit test config commands #1607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle previous npx options that are still possible to be handled, and print a warning if any deprecated/removed options are used. - expand shorthands properly in npx command line. - take existing npm options into account when determining placement of the -- argument. - document changes from previous versions of npx. PR-URL: #1596 Credit: @isaacs Close: #1596 Reviewed-by: @ruyadorno
Update the matrix to have two Windows workflows: one running PowerShell and one running bash.
The `tap` package bundles `import-jsx`, which in turn bundles `@babel/core` and a bunch of other stuff. However, even though `@babel/core` is in the bundle, it's getting placed in the tree at the root. This is a mistake. Because the node is placed, and not given the `extraneous` flag, in the ideal tree building process, when reified, it goes ahead and puts it in place. When reading the actual tree, we see a valid hidden lockfile, which contains the module, and it doens't have the extraneous flag. So everything seems fine. Remove the hidden lockfile, and the problem presents itself. Corrected here through some arduous and painstaking manual installs, so at least we have the tree in the state it *should* be for now. But this is a bug in arborist that must be fixed asap. Re: #1597
There's still a task pending to get it actually up to date with non-conflicting peer deps and everything updated to remove deprecated and outdated packages. But at least it builds at all now.
Still pending test coverage for most of these, but wanted to give them a
clean sweep to get the "load-all-commands" tests passing.
The following changes are in here:
- All commands now have a `completion()` method and a usage string that
uses the same `usage` util consistently.
- The `silent` argument to many commands has been removed.
- All commands use the `cmd = ${cmd}(args).then(() => cb()).catch(cb)`
pattern consistently.
Full test coverage for all commands is still lacking, and will have to
be done prior to the GA v7 release.
Arrays of string literals are fine, and we're only using it in one place.
isaacs
force-pushed
the
release/v7.0.0-beta
branch
2 times, most recently
from
81f5a05 to
835c1aa
Compare
darcyclarke
added
the
Release 7.x
|
replaced by #2001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor and add unit tests for config commands
based on isaacs/remove-deps-no-longer-used