Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli,outdated: default homepage to an empty string #124

Merged

Conversation

anchnk
Copy link
Contributor

@anchnk anchnk commented Dec 17, 2018

This patch default package's homepage to an empty string in case the
homepage isn't specificied in the package manifest.

Before this patch, if at least one package didn't set an associated
homepage, running npm outdated --long would break.

After this patch, it won't display anything for this specific package
Homepage row and it won't break for the other packages.

This patch default package's homepage to an empty string in case the
homepage isn't specificied in the package manifest.

Before this patch, if at least one package didn't set an associated
homepage, running npm outdated --long would break.

After this patch, it won't display anything for this specific package
Homepage row and it won't break for the other packages.
@anchnk anchnk requested a review from a team as a code owner December 17, 2018 17:24
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch!

@zkat zkat changed the base branch from latest to release-next December 17, 2018 17:39
@zkat zkat added the semver:patch semver patch level for changes label Dec 17, 2018
@aeschright aeschright merged commit a5c9e6f into npm:release-next Jan 9, 2019
aeschright pushed a commit that referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants