Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates term-size to use signed binary #1053

Closed
wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Mar 23, 2020

Downstream node is patching term-size in order to avoid failing release builds, see: nodejs/node#32403

Given that npm@6 has to support node 6 and that dependency chain [term-size] is long enough, along with many major bumps dropping node6 along the way. I propose we patch it here same as node downstream.

ref: sindresorhus/terminal-size#16

Upstream node is patching `term-size` in order to avoid failing release
builds, see: nodejs/node#32403

Given that npm@6 has to support node6 and that dependency chain is long
enough, along with many major bumps dropping node6 along the way. I
propose we patch it here same as node upstream.

- ref: sindresorhus/terminal-size#16
@ruyadorno ruyadorno requested a review from a team as a code owner March 23, 2020 21:26
@ruyadorno ruyadorno added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Mar 23, 2020
@isaacs
Copy link
Contributor

isaacs commented Mar 23, 2020

LGTM!

@sam-github
Copy link

I suggest that spawning an executable to make an ioctl that can be made through pure js with existing builtin Node.js APIs is not really the way to go, perhaps its worth choosing box drawing dependencies that don't do that?

sindresorhus/terminal-size#15

@ruyadorno ruyadorno mentioned this pull request Mar 24, 2020
@ruyadorno
Copy link
Contributor Author

@sam-github thanks for bringing that up, we're currently revisiting update-notifier usage: npm/rfcs#118 and that extra info is def appreciated 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants