Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] package binaries with .hidden folders don't install globally #7728

Closed
2 tasks done
thepiwo opened this issue Aug 16, 2024 · 2 comments
Closed
2 tasks done

[BUG] package binaries with .hidden folders don't install globally #7728

thepiwo opened this issue Aug 16, 2024 · 2 comments
Assignees
@milaninfy
Labels
Bug thing that needs fixing Priority 2 secondary priority issue

Comments

@thepiwo
Copy link

thepiwo commented Aug 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

With nodejs 20.16.0 (npm 10.8.1) global install seems to not install binaries from hidden folders.

e.g.

"bin": {
    "debug-bin": ".build/cli.js"
  },

Expected Behavior

With nodejs 20.15.1 (npm 10.7.0) it still worked.

Steps To Reproduce

I described steps to reproduce the issue in a repository with an example: https://github.com/thepiwo/nodejs-debug-bin

Environment

  • npm: 10.8.1
  • node: 20.16.0
@thepiwo thepiwo added Bug thing that needs fixing Needs Triage needs review for next steps labels Aug 16, 2024
@milaninfy
Copy link
Contributor

Reproduced the issue locally with 10.8.1. works fine on 10.8.0.

@milaninfy milaninfy added Priority 2 secondary priority issue and removed Needs Triage needs review for next steps labels Aug 22, 2024
@milaninfy milaninfy mentioned this issue Sep 4, 2024
Merged
@milaninfy milaninfy self-assigned this Sep 6, 2024
wraithgar pushed a commit to npm/package-json that referenced this issue Sep 17, 2024
@milaninfy
fix: hidden dir path clean up corrected (#119)
962b9e1 
Path normalization done in #105
resulted in the removal of `bin` paths that start with `. (hidden
directory)`. This PR corrects the path normalization to allow `bin`
paths that start with `. (hidden directory)`.


## References
Fixes #116 &
npm/cli#7728
@milaninfy
Copy link
Contributor

fixed in npm/package-json#119

@7crabs 7crabs mentioned this issue Sep 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milaninfy milaninfy

Labels
Bug thing that needs fixing Priority 2 secondary priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thepiwo @milaninfy