Skip to content

Commit

Permalink
fix(tests): increase test fuzziness
Browse files Browse the repository at this point in the history
These tests periodically fail in CI, 10 milliseconds is very much not
enough time to account for fuzziness, and 5 minutes is more than enough
precision given the scales of time involved in each test.
  • Loading branch information
wraithgar committed May 6, 2021
1 parent 049166b commit 92f4346
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/lib/utils/update-notifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,15 @@ t.test('situations in which we do not notify', t => {
})

t.test('only check weekly for GA releases', async t => {
// the 10 is fuzz factor for test environment
STAT_MTIME = Date.now() - (1000 * 60 * 60 * 24 * 7) + 10
// One week (plus five minutes to account for test environment fuzziness)
STAT_MTIME = Date.now() - (1000 * 60 * 60 * 24 * 7) + (1000 * 60 * 5)
t.equal(await updateNotifier(npm), null)
t.strictSame(MANIFEST_REQUEST, [], 'no requests for manifests')
})

t.test('only check daily for betas', async t => {
// the 10 is fuzz factor for test environment
STAT_MTIME = Date.now() - (1000 * 60 * 60 * 24) + 10
// One day (plus five minutes to account for test environment fuzziness)
STAT_MTIME = Date.now() - (1000 * 60 * 60 * 24) + (1000 * 60 * 5)
t.equal(await updateNotifier({ ...npm, version: HAVE_BETA }), null)
t.strictSame(MANIFEST_REQUEST, [], 'no requests for manifests')
})
Expand Down

0 comments on commit 92f4346

Please sign in to comment.