Skip to content

Commit

Permalink
fix: remove metric-registry config
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the hard-coded "metrics-registry" config has been
removed.

This is not used by npm at all, and is also not used by any of the npm
modules that consume config.  npm does not send data to any metrics
server.
  • Loading branch information
wraithgar authored and lukekarrys committed Jul 26, 2023
1 parent b6cf113 commit 1f767aa
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions workspaces/config/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,6 @@ class Config {

const { data } = this.data.get('default')

// the metrics-registry defaults to the current resolved value of
// the registry, unless overridden somewhere else.
settableGetter(data, 'metrics-registry', () => this.#get('registry'))

// if the prefix is set on cli, env, or userconfig, then we need to
// default the globalconfig file to that location, instead of the default
// global prefix. It's weird that `npm get globalconfig --prefix=/foo`
Expand Down

0 comments on commit 1f767aa

Please sign in to comment.