fixup! feat: write eresolve error files to the logs directory

npm · Sep 26, 2022 · 0aaafe5 · 0aaafe5
1 parent 7bbd88f
commit 0aaafe5
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/lib/npm.js b/lib/npm.js
@@ -370,8 +370,8 @@ class Npm extends EventEmitter {
     return this.config.get('logs-dir') || join(this.cache, '_logs')
   }
 
-  logPath = (file = '') => {
-    return resolve(this.logsDir, `${this.#runId}-${file}`)
+  get logPath () {
+    return resolve(this.logsDir, `${this.#runId}-`)
   }
 
   get timingFile () {

diff --git a/lib/utils/exit-handler.js b/lib/utils/exit-handler.js
@@ -183,7 +183,7 @@ const exitHandler = err => {
       const { summary, detail, files = [] } = errorMessage(err, npm)
 
       for (let [file, content] of files) {
-        file = npm.logPath(file)
+        file = `${npm.logPath}${file}`
         content = `'Log files:\n${npm.logFiles.join('\n')}\n\n${content.trim()}\n`
         try {
           fs.withOwnerSync(

diff --git a/lib/utils/log-file.js b/lib/utils/log-file.js
@@ -77,7 +77,7 @@ class LogFiles {
       return
     }
 
-    log.verbose('logfile', `logs-max:${logsMax} dir:${this.#path()}`)
+    log.verbose('logfile', `logs-max:${logsMax} dir:${this.#path}`)
 
     // Pipe our initial stream to our new file stream and
     // set that as the new log logstream for future writes
@@ -157,7 +157,7 @@ class LogFiles {
   }
 
   #getLogFilePath (count = '') {
-    return this.#path(`debug-${count}.log`)
+    return `${this.#path}debug-${count}.log`
   }
 
   #openLogFile () {

diff --git a/lib/utils/timers.js b/lib/utils/timers.js
@@ -69,7 +69,7 @@ class Timers extends EE {
 
   load ({ path } = {}) {
     if (path) {
-      this.file = path('timing.json')
+      this.file = `${path}timing.json`
     }
   }
 

diff --git a/test/lib/utils/exit-handler.js b/test/lib/utils/exit-handler.js
@@ -345,9 +345,7 @@ t.test('files from error message with error', async (t) => {
       '@npmcli/fs': {
         ...fs,
         writeFileSync: (dir) => {
-          console.log(dir)
           if (dir.includes('LOGS_DIR') && dir.endsWith('error-file.txt')) {
-            console.log('throw')
             throw new Error('err')
           }
         },

diff --git a/test/lib/utils/log-file.js b/test/lib/utils/log-file.js
@@ -49,7 +49,7 @@ const loadLogFile = async (t, { buffer = [], mocks, testdir = {}, ...options } =
   buffer.forEach((b) => logFile.log(...b))
 
   const id = getId()
-  await logFile.load({ path: (f = '') => path.join(root, `${id}-${f}`), ...options })
+  await logFile.load({ path: path.join(root, `${id}-`), ...options })
 
   t.teardown(() => logFile.off())
   return {

diff --git a/test/lib/utils/timers.js b/test/lib/utils/timers.js
@@ -72,7 +72,7 @@ t.test('writes file', async (t) => {
   const dir = t.testdir()
   process.emit('time', 'foo')
   process.emit('timeEnd', 'foo')
-  timers.load({ path: (f) => resolve(dir, `TIMING_FILE-${f}`) })
+  timers.load({ path: resolve(dir, `TIMING_FILE-`) })
   timers.writeFile({ some: 'data' })
   const data = JSON.parse(fs.readFileSync(resolve(dir, 'TIMING_FILE-timing.json')))
   t.match(data, {
@@ -88,7 +88,7 @@ t.test('fails to write file', async (t) => {
   const { logs, timers } = mockTimers(t)
   const dir = t.testdir()
 
-  timers.load({ path: () => join(dir, 'does', 'not', 'exist') })
+  timers.load({ path: join(dir, 'does', 'not', 'exist') })
   timers.writeFile()
 
   t.match(logs.warn, [['timing', 'could not write timing file']])