This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
behave properly when root is a symlink in build-ideal-tree #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/root-ideal-tree-symlink
branch
from
0b86538 to
5dfd0a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an effort to make the ideal tree more closely resemble reality, when we know the root is a Link we should build our ideal tree also rooted on a Link so that the diffing algorithm works as expected.
as a bonus, this also removes the build-ideal-tree test specific printable tree in favor of using the now built-in toJSON method on the trees.