do not elide edges in explain() output when a root edge exists

npm · Oct 21, 2020 · 1d710cb · 1d710cb
1 parent 1742524
commit 1d710cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/lib/node.js b/lib/node.js
@@ -369,19 +369,13 @@ class Node {
     if (edge)
       why.dependents.push(edge.explain(seen))
     else {
-      // if we have an edge from the root, just show that, and stop there
-      // no need to go deeper, because it doesn't provide much more value.
+      // ignore invalid edges, since those aren't satisfied by this thing,
+      // and are not keeping it held in this spot anyway.
       const edges = []
       for (const edge of this.edgesIn) {
         if (!edge.valid && !edge.from.isRoot)
           continue
 
-        if (edge.from.isRoot) {
-          edges.length = 0
-          edges.push(edge)
-          break
-        }
-
         edges.push(edge)
       }
       for (const edge of edges)

diff --git a/test/node.js b/test/node.js
@@ -1617,6 +1617,5 @@ t.test('explain yourself', t => {
     package: { noname: 'bad', noversion: 'node' },
   })
 
-
   t.end()
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -1617,6 +1617,5 @@ t.test('explain yourself', t => { @@
         package: { noname: 'bad', noversion: 'node' },
       })
       t.end()
     })