Add extension distance methods with useSpheroid

[tiborfsk]

#1638

[roji]

Thanks, that looks pretty good! See comments below on the extension methods, and can you please also add tests in SpatialQueryNpgsqlGeometryTest?

[tiborfsk]

Thanks, that looks pretty good! See comments below on the extension methods, and can you please also add tests in SpatialQueryNpgsqlGeometryTest?

Okay. Please why are some AssertSql calls commented out in some of the test cases in SpatialQueryNpgsqlGeometryTest?

[roji]

Please why are some AssertSql calls commented out in some of the test cases in SpatialQueryNpgsqlGeometryTest?

The commented assertions are only on the SQL that gets generated - the actual functionality still gets tested (via the base class). In the EFCore.PG provider we don't systematically assert SQLs for all tests (like in the SqlServer provider), since SQL has tended to change in various ways because of upstream EF changes (and reacting every time takes a lot of effort). But you're right that we should clean this up here.

It would be great if you could assert SQL for the specific test you're adding, I'll try to clean up the rest soon.

[roji]

Thanks, that looks great!