Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support INCLUDE for indexes (PG11) #697

Closed
oguzhantopcu opened this issue Nov 13, 2018 · 6 comments
Closed

Support INCLUDE for indexes (PG11) #697

oguzhantopcu opened this issue Nov 13, 2018 · 6 comments
Labels
enhancement New feature or request
Milestone
2.2.0

Comments

@oguzhantopcu
Copy link

https://paquier.xyz/postgresql-2/postgres-11-covering-indexes/

Is there any way to add covering index via fluent mapping? If there is not, is it possible to implement?
@austindrenski
Copy link
Contributor

austindrenski commented Nov 13, 2018 •
edited
Loading

I don't believe we've implemented any PG11 features yet, but we are certainly open to it.

Could you link to the official docs for the feature you're requesting, as well as provide some snippets (psuedo-code where necessary) of what you're envisioning?

@YohDeadfall
Copy link
Contributor

It's a usual index with INCLUDEd columns (docs). The implementation could be taken from dotnet/efcore#12266 which was for SQL Server.

@austindrenski
Copy link
Contributor

Ah, that makes sense. In that case we could probably put something together for this after #662.

@austindrenski austindrenski changed the title Covering Index Support Support INLCUDE for indexes (PG11) Nov 13, 2018
@austindrenski austindrenski added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2018
@roji roji added this to the 2.2.0 milestone Nov 14, 2018
@austindrenski
Copy link
Contributor

@khellang Since you were just working in this area, would you be interested in submitting a PR?

@khellang
Copy link
Contributor

Sure. I'll look into it tonight 👍🏻

@khellang khellang mentioned this issue Nov 14, 2018
Merged
@YohDeadfall YohDeadfall removed the good first issue Good for newcomers label Nov 14, 2018
@roji roji changed the title Support INLCUDE for indexes (PG11) Support INCLUDE for indexes (PG11) Nov 15, 2018
@roji roji closed this as completed in #699 Nov 16, 2018
@roji
Copy link
Member

roji commented Nov 16, 2018

Merged, thanks @khellang!

roji added a commit to roji/efcore.pg that referenced this issue Nov 17, 2018
@roji
Scaffold included (covered) index columns
5ed5804 
See npgsql#697, npgsql#704
roji added a commit to roji/efcore.pg that referenced this issue Nov 17, 2018
@roji
Scaffold included (covered) index columns
1827dde 
See npgsql#697, npgsql#704
roji added a commit to roji/efcore.pg that referenced this issue Nov 17, 2018
@roji
Scaffold included (covered) index columns
79f86da 
See npgsql#697, npgsql#704
roji added a commit that referenced this issue Nov 17, 2018
@roji
Scaffold included (covered) index columns
8deecec 
See #697, #704
austindrenski pushed a commit to austindrenski/npgsql-efcore.pg that referenced this issue Nov 18, 2018
@roji @austindrenski
Scaffold included (covered) index columns
67cfb0c 
See npgsql#697, npgsql#704
@springy76 springy76 mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
5 participants
@khellang @roji @oguzhantopcu @YohDeadfall @austindrenski