Add noise_level_bounds to WhiteKernel #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the parameter noise_level_bounds to the constructor of GaussianProcessRegressor. The parameter sets the noise level bounds of the WhiteKernel used when noise is set to "gaussian". The default values are the same as the default values of the WhiteKernel constructor.
Describe the purpose of of noise_level_bounds
|
@abbl-DTI could you have a look at this change? |
|
Looking good. What will happen if user gives a noise estimate in the noise parameter - and if that estimate is outside the bounds of the noise-range? |
|
noise_level_bounds is only used when noise = "gaussian", so in the case you mention the bounds will not be used for anything. As I understand it, the only way to get a tunable noise is by setting noise="gaussian", so I figured that was a sensible behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the parameter noise_level_bounds to the constructor of GaussianProcessRegressor. The parameter sets the noise level bounds of the WhiteKernel used when noise is set to "gaussian". The default values are the same as the default values of the WhiteKernel constructor.
This pull request opens up for solving the issue #95 by changing the noise level bounds.