Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TokenFileName maybe a better way #567

Closed
wants to merge 3 commits into from

Conversation

shifengbin
Copy link
Contributor

TokenFileName maybe a better way

@CendioOssman
Copy link
Member

Thanks, this could possibly be interesting. But it is also more dangerous as there is a risk that an attacker tricks us in to opening files we're not supposed to, and leaking sensitive data. So we need to have some protections in place.

Could you describe your use case a bit, and why the existing plugins weren't a good fit?

@shifengbin
Copy link
Contributor Author

shifengbin commented Jan 15, 2024

in order to facilitate debugging and retrieval. It's difficult to find many tokens distributed in multiple files.

@CendioOssman
Copy link
Member

Squashed and merged in 0427f63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants