Feature/generic signed extensions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
valentunn
commented
Sep 29, 2023
valentunn
commented
- Make both Extrinsic and ExtrinsicPayloadExtras determine types solely based on runtime metadata
- For v14 runtimes, use types specified in RuntimeMetadata
- For v13 runtimes, use the default signed extension
- Clients no longer need to pass types for custom signed extensions
valentunn
commented
Sep 29, 2023
| companion object { | ||
| fun default(): SiTypeMapping { | ||
| return ReplaceTypesSiTypeMapping( | ||
| "sp_runtime.generic.era.Era" to EraType |
There was a problem hiding this comment.
We no longer hard-code EraType in SignedExtensions so we need to replace it at type parsing stage to use our own EraType instead of metadata v14 version
fix spelling push cargo toml change location fix syntax remove fmt remove semicolon from expression remove directory switching adding ndk change installation action and add crago-c fix syntax remove cargo-c return toolchain back try to install libgcc fix syntx adding sudo update version of image remove toolchain update version return installation through action decrease version try to install target separatelly fix shell add gcc-multilib fix syntax change to macos install all libraries fix syntax E: Unable to locate package lib32ncurses5 try to fix libgcc problem change to stable version adding aarch64-linux-android
stepanLav
force-pushed
the
feature/generic_signed_extensions
branch
from
6191387 to
092c4ac
Compare
stepanLav
approved these changes
Oct 1, 2023
Merged
stepanLav
added a commit
that referenced
this pull request
Oct 15, 2023
* Rework signed extensions * Code style * Bump versions * Comments * Handle nonce as struct * Handle nonce as struct * update image link * change to using install workflow * Force older version of log * change install dep fix spelling push cargo toml change location fix syntax remove fmt remove semicolon from expression remove directory switching adding ndk change installation action and add crago-c fix syntax remove cargo-c return toolchain back try to install libgcc fix syntx adding sudo update version of image remove toolchain update version return installation through action decrease version try to install target separatelly fix shell add gcc-multilib fix syntax change to macos install all libraries fix syntax E: Unable to locate package lib32ncurses5 try to fix libgcc problem change to stable version adding aarch64-linux-android * update other actions * remove debug info * remove additional libraries --------- Co-authored-by: Stepan Lavrentev <lawrentievsv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.