fix: signing button postion #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjeohp-zz
previously approved these changes
Mar 19, 2020
hanwencheng
force-pushed
the
hanwen-signing-button
branch
from
75c4d68
to
aff0396
Compare
sjeohp-zz
approved these changes
Mar 23, 2020
pmespresso
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR based on #562 .
Improve on the signing button. and also fix the buttonn display on big screens (e.g. iPhone X).
Signing button
before fix the "sign transaction" button is floating with fix position, which will cover the transaction information. now it is on the end of the screen.
Signing Message button in big screen
The "signing message" button do not have fix position, but it extends to the whole screen width when displayed in big screen, now change to fit screen.