Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Polkadot support #555

Merged
merged 19 commits into from
Mar 13, 2020
Merged

feat: add Polkadot support #555

merged 19 commits into from
Mar 13, 2020

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Mar 9, 2020

closes #547 ; closes #546

Add polkadot account generation support, Prepare for the polkadot release.

Add full support for Kulupu and Edgeware.

How to Test:

  1. Account Generation and Deletion should work for Polkadot
  2. Signing request for Edgeware / Kulupu should be possible.
  3. Signing Request for Kusama should not be broken.

Passed e2e, unit, and lint test.

@hanwencheng hanwencheng self-assigned this Mar 9, 2020
@hanwencheng hanwencheng changed the title Hanwen upgrade polkadot Add Polkadot support Mar 9, 2020
@hanwencheng hanwencheng changed the title Add Polkadot support feat: add Polkadot support Mar 9, 2020
@hanwencheng hanwencheng changed the base branch from master to hanwen-westend March 9, 2020 17:39
@hanwencheng hanwencheng changed the base branch from hanwen-westend to master March 11, 2020 13:00
Comment on lines 134 to 139
const infinity = 999;
const getOrder = (param: NetworkParams): number => {
if (isEthereumNetworkParams(param)) return infinity;
if (isUnknownNetworkParams(param)) return 0;
return (param as SubstrateNetworkParams).order ?? infinity - 1;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fragile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this part, now give each network a order field in order to make an explicit sorting.

In the future it would be nice to enable user to drag network in the list and re-order them. This could be implement after we have custom network feature ready with #524.

@hanwencheng hanwencheng requested a review from sjeohp-zz March 12, 2020 13:14
@hanwencheng hanwencheng merged commit 9e8d39e into master Mar 13, 2020
@hanwencheng hanwencheng deleted the hanwen-upgrade-polkadot branch March 13, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kulupu support Add Edgeware support
3 participants