-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Polkadot support #555
Conversation
const infinity = 999; | ||
const getOrder = (param: NetworkParams): number => { | ||
if (isEthereumNetworkParams(param)) return infinity; | ||
if (isUnknownNetworkParams(param)) return 0; | ||
return (param as SubstrateNetworkParams).order ?? infinity - 1; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fragile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this part, now give each network a order
field in order to make an explicit sorting.
In the future it would be nice to enable user to drag network in the list and re-order them. This could be implement after we have custom network feature ready with #524.
closes #547 ; closes #546
Add polkadot account generation support, Prepare for the polkadot release.
Add full support for Kulupu and Edgeware.
How to Test:
Passed e2e, unit, and lint test.