fix: pin input text and return button #520
Merged
+70
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #518 , closes #519
Unlock pin Input Text
4a30916 : is for #518, now the text is changed, and all the text in
IdentityNew
is ordered into a object/map calledt
.Return button in text input component
The other three commits are for #519 , the main fix is in dc8d65e , which add
onSubmitEditing
for TextInput Component. Other two commits is mainly for e2e tests.The unfunctioned button is not only in Android but also in iOS, now I have address all the return button in both platforms:
How to test:
for above 1 and 2, try create any path from a Kusama network:
for above 3 and 4, try recovery an identity with any seed: