Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin input text and return button #520

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Jan 8, 2020

closes #518 , closes #519

Unlock pin Input Text

4a30916 : is for #518, now the text is changed, and all the text in IdentityNew is ordered into a object/map called t.

Screen Shot 2020-01-08 at 20 09 49

Return button in text input component

The other three commits are for #519 , the main fix is in dc8d65e , which add onSubmitEditing for TextInput Component. Other two commits is mainly for e2e tests.
The unfunctioned button is not only in Android but also in iOS, now I have address all the return button in both platforms:

  1. in path derivation process, path input and account name input.
  2. in pin unlock screen, pin input
  3. in pin creation screen, pin input
  4. in path recovery screen, seed input

How to test:

for above 1 and 2, try create any path from a Kusama network:

out

for above 3 and 4, try recovery an identity with any seed:

android ios
out_android out

@hanwencheng hanwencheng requested review from kirushik and Tbaut January 8, 2020 19:32
@hanwencheng hanwencheng self-assigned this Jan 8, 2020
@hanwencheng hanwencheng changed the title Hanwen pin input text fix: pin input text and return button Jan 8, 2020
@hanwencheng hanwencheng added this to the v4.0 HDKD milestone Jan 8, 2020
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had some slowness in typing the pin, but my phone is generally slow so I expect it doesn't come from the code.
I tried to break it by typing the keyboard submit and the button and nothing unexpected happened (we had some problems in the past due to double submission).

I did not test any transaction as I don't expect this PR to break anything.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hanwencheng
Copy link
Contributor Author

hanwencheng commented Jan 9, 2020

@Tbaut Does the slowness also happens before this PR? what about the seed input in recovery page?

@Tbaut
Copy link
Contributor

Tbaut commented Jan 9, 2020

it's really random, you can disregard that comment, I didn't have the problem any more, on master or this branch..

@hanwencheng hanwencheng merged commit cda2c04 into master Jan 9, 2020
@hanwencheng hanwencheng deleted the hanwen-pin-input-text branch January 9, 2020 15:21
Copy link

@kirushik kirushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at e2e part of the PR, haven't actually tested the build.

Proposed feature solves my point, code seems legit and doing what it should be doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - The submit key on the keyboard doesn't do anything Misleading PIN helper text
3 participants