-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable path derivation from existed path card #516
Conversation
7d58592
to
9ebfa68
Compare
Also I am also thinking about the renaming of the button from |
Regarding the naming (add "child"), I don't mind, not sure it clarifies anything though. One thing for sure, we need to unify the naming. We have "derive account", then on the button "derive address". Regarding this PR, just looking at the presentation, I think it's confusing that the workflow is different (not a button but a menu entry) but in the end the behaviour is the same as the "derive account" button. I feel that for the same behaviour, we should have the same flow. Any thought on that? |
True, will change that.
The behavoir is different, take a look at the path, this derive path start with the path of the current select account, in the above example, it is Do not have any feature request from users, just personally think that would be useful. |
Change the related text. From the comments I realize that the derive base path is hard to distinguish. So in the commit: So now the subtitle always shows the base path of the derivation. For example, in the flow:
|
A small feature which ease the path creation process.
How to test:
Select Kusama network -> select any path -> tap top right menu button -> tap "Derive Account" button -> path derivation card should be a pre-filled path, and path creation should be correct.
At the same time, other path derivation should keep the same as before, which is: