Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent signing with unknown sender #475

Merged
merged 2 commits into from
Nov 27, 2019
Merged

fix: prevent signing with unknown sender #475

merged 2 commits into from
Nov 27, 2019

Conversation

hanwencheng
Copy link
Contributor

fix #474

pmespresso
pmespresso reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you had a check for sender identitty not found, then removed it. Any reason for that? IMO it's better to have the Alert.

@hanwencheng
Copy link
Contributor Author

hanwencheng commented Nov 26, 2019 •
edited
Loading

Yeah, I finally removed that check. That situation actually will never happen. The sender in this case is from getById, and here we already have the check if sender is find, so that sender is never be null if it is not legacy account.

pmespresso
pmespresso approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@pmespresso pmespresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@pmespresso pmespresso mentioned this pull request Nov 26, 2019
Closed
@pmespresso pmespresso merged commit f67dcac into master Nov 27, 2019
@pmespresso pmespresso deleted the hanwen-fix-unknown-signing branch November 27, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjeohp-zz sjeohp-zz sjeohp-zz approved these changes

@pmespresso pmespresso pmespresso approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scanning a transaction from an unknown sender does not report error.
3 participants
@hanwencheng @sjeohp-zz @pmespresso