Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove version in "About" to fix CI #463

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Nov 21, 2019

This code was just tiny little "nice to have" but it's responsible for one of the error that ./android/gradlew assembleRelease throws when building an unsigned apk:

Error: package is not a valid resource name (reserved Java keyword)

This is solved by react-native 0.61 but for now I just want to see what the CI bumps into next.

@Tbaut Tbaut merged commit 6dc669a into master Nov 22, 2019
@Tbaut Tbaut deleted the tbaut-without-version branch November 22, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants